-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include omit entries in hash #3552
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
@@ -977,6 +977,8 @@ impl Asset for EcmascriptChunk { | |||
hasher.write_value(id.await?); | |||
need_hash = true; | |||
} | |||
// Marker to end evaluate | |||
hasher.write_value(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have written a length header instead of a bool footer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both evaluate
and omit
could write length headers (or 0
when N/A).
Benchmark for 29569da
Click to view full benchmark
|
|
Benchmark for 4f716e0
Click to view full benchmark
|
Benchmark for f00ca10
Click to view full benchmark
|
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turborepo#3540 - vercel/turborepo#3549 - vercel/turborepo#3465 - vercel/turborepo#3550 - vercel/turborepo#3495 - vercel/turborepo#3624 - vercel/turborepo#3600 - vercel/turborepo#3676 - vercel/turborepo#3689 # Fixes - vercel/turborepo#3437 - vercel/turborepo#3542 - vercel/turborepo#3531 - vercel/turborepo#3552 - vercel/turborepo#3551 - vercel/turborepo#3597 - vercel/turborepo#3644 - vercel/turborepo#3623 - vercel/turborepo#3634 - vercel/turborepo#3574 - vercel/turborepo#3673 - vercel/turborepo#3675 - vercel/turborepo#3723 - vercel/turborepo#3677 - vercel/turborepo#3717 - vercel/turborepo#3701 # Performance Improvements - vercel/turborepo#3361 - vercel/turborepo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ